Update tooltip only when active element has changed (#3856)

Resolves #3746
This commit is contained in:
Jerry 2017-02-10 15:51:37 -08:00 committed by Evert Timberg
parent 9f3b51a80c
commit 8f217182b8
2 changed files with 67 additions and 0 deletions

View File

@ -781,6 +781,12 @@ module.exports = function(Chart) {
// Remember Last Actives
changed = !helpers.arrayEquals(me._active, me._lastActive);
// If tooltip didn't change, do not handle the target event
if (!changed) {
return false;
}
me._lastActive = me._active;
if (options.enabled || options.custom) {

View File

@ -674,4 +674,65 @@ describe('Core.Tooltip', function() {
expect(tooltip._view.dataPoints[0].x).toBeCloseToPixel(point._model.x);
expect(tooltip._view.dataPoints[0].y).toBeCloseToPixel(point._model.y);
});
it('Should not update if active element has not changed', function() {
var chart = window.acquireChart({
type: 'bar',
data: {
datasets: [{
label: 'Dataset 1',
data: [10, 20, 30],
pointHoverBorderColor: 'rgb(255, 0, 0)',
pointHoverBackgroundColor: 'rgb(0, 255, 0)'
}, {
label: 'Dataset 2',
data: [40, 40, 40],
pointHoverBorderColor: 'rgb(0, 0, 255)',
pointHoverBackgroundColor: 'rgb(0, 255, 255)'
}],
labels: ['Point 1', 'Point 2', 'Point 3']
},
options: {
tooltips: {
mode: 'single',
callbacks: {
title: function() {
return 'registering callback...';
}
}
}
}
});
// Trigger an event over top of the
var meta = chart.getDatasetMeta(0);
var firstPoint = meta.data[1];
var node = chart.chart.canvas;
var rect = node.getBoundingClientRect();
var firstEvent = new MouseEvent('mousemove', {
view: window,
bubbles: false,
cancelable: true,
clientX: rect.left + firstPoint._model.x,
clientY: rect.top + firstPoint._model.y
});
var tooltip = chart.tooltip;
spyOn(tooltip, 'update');
/* Manually trigger rather than having an async test */
// First dispatch change event, should update tooltip
node.dispatchEvent(firstEvent);
expect(tooltip.update).toHaveBeenCalledWith(true);
// Reset calls
tooltip.update.calls.reset();
// Second dispatch change event (same event), should not update tooltip
node.dispatchEvent(firstEvent);
expect(tooltip.update).not.toHaveBeenCalled();
});
});