archive-gh-me/Chart.js
1
0
Fork 0
mirror of https://github.com/chartjs/Chart.js.git synced 2025-12-08 20:36:08 +00:00
Code Issues Projects Releases Wiki Activity

Add sanity check for stepSize (#9679)

Browse Source
This commit is contained in:
Jukka Kurkela 2021-09-25 01:13:10 +03:00 committed by GitHub
parent 8e68481ec4
commit 5587738fa4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/scales/scale.linearbase.js
View File

@ -222,6 +222,10 @@ export default class LinearScaleBase extends Scale {
if (stepSize) {
maxTicks = Math.ceil(this.max / stepSize) - Math.floor(this.min / stepSize) + 1;
if (maxTicks > 1000) {
console.warn(`scales.${this.id}.ticks.stepSize: ${stepSize} would result generating up to ${maxTicks} ticks. Limiting to 1000.`);
maxTicks = 1000;
}
} else {
maxTicks = this.computeTickLimit();
maxTicksLimit = maxTicksLimit || 11;

23
test/specs/scale.linear.tests.js
View File

@ -639,6 +639,29 @@ describe('Linear Scale', function() {
expect(getLabels(chart.scales.y)).toEqual(['1', '3', '5', '7', '9', '11']);
});
it('Should not generate insane amounts of ticks with small stepSize and large range', function() {
var chart = window.acquireChart({
type: 'bar',
options: {
scales: {
y: {
type: 'linear',
min: 1,
max: 1E10,
ticks: {
stepSize: 2,
autoSkip: false
}
}
}
}
});
expect(chart.scales.y.min).toBe(1);
expect(chart.scales.y.max).toBe(1E10);
expect(chart.scales.y.ticks.length).toBeLessThanOrEqual(1000);
});
it('Should create decimal steps if stepSize is a decimal number', function() {
var chart = window.acquireChart({
type: 'bar',