archive-gh-me/Chart.js
1
0
Fork 0
mirror of https://github.com/chartjs/Chart.js.git synced 2025-12-08 20:36:08 +00:00
Code Issues Projects Releases Wiki Activity

Address bar chart performance regression (#7234)

Browse Source
This commit is contained in:
Ben McCann 2020-03-30 14:31:54 -07:00 committed by GitHub
parent 3f58edbe80
commit 48a6a8d130
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/controllers/controller.bar.js
View File

@ -66,14 +66,10 @@ function computeMinSampleSize(scale, pixels) {
function computeFitCategoryTraits(index, ruler, options) {
const thickness = options.barThickness;
const count = ruler.stackCount;
const curr = ruler.pixels[index];
const min = isNullOrUndef(thickness)
? computeMinSampleSize(ruler.scale, ruler.pixels)
: -1;
let size, ratio;
if (isNullOrUndef(thickness)) {
size = min * options.categoryPercentage;
size = ruler.min * options.categoryPercentage;
ratio = options.barPercentage;
} else {
// When bar thickness is enforced, category and bar percentages are ignored.
@ -86,7 +82,7 @@ function computeFitCategoryTraits(index, ruler, options) {
return {
chunk: size / count,
ratio,
start: curr - (size / 2)
start: ruler.pixels[index] - (size / 2)
};
}
@ -385,7 +381,14 @@ export default class BarController extends DatasetController {
pixels.push(iScale.getPixelForValue(me.getParsed(i)[iScale.axis]));
}
// Note: a potential optimization would be to skip computing this
// only if the barThickness option is defined
// Since a scriptable option may return null or undefined that
// means the option would have to be of type number
const min = computeMinSampleSize(iScale, pixels);
return {
min,
pixels,
start: iScale._startPixel,
end: iScale._endPixel,